Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add native image reflect-config.json to gax-grpc #1251

Merged
merged 12 commits into from Jan 19, 2023
Merged

fix: Add native image reflect-config.json to gax-grpc #1251

merged 12 commits into from Jan 19, 2023

Conversation

burkedavison
Copy link
Contributor

@burkedavison burkedavison commented Jan 17, 2023 •
edited

Same changes as #1246, but with a simpler commit history and diff.

@burkedavison burkedavison requested a review from a team as a code owner January 17, 2023 17:56
@burkedavison
Copy link
Contributor Author

Kokoro changes not being reflected in the builds. May take an hour or so.

@burkedavison burkedavison added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jan 17, 2023
@burkedavison burkedavison added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
mpeddada1
mpeddada1 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion to have the grpc-netty configs live in the GrpcNettyFeature class

@burkedavison burkedavison added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@burkedavison burkedavison merged commit ff2d118 into main Jan 19, 2023
@burkedavison burkedavison deleted the gax-grpc-reflect-config-2 branch January 19, 2023 18:56
@release-please release-please bot mentioned this pull request Jan 19, 2023
Merged
lqiu96 pushed a commit that referenced this pull request Jan 25, 2023
@burkedavison @lqiu96
fix: Add native image reflect-config.json to gax-grpc (#1251)
a284a5e 
* fix: Add native image reflect-config.json to gax-grpc

* fix: Place all netty reflect configurations in GrpcNettyFeature.java

* fix: format

* ci: downstream test graalvm native image compilation on java-kms and java-os-login

* fix: register full classes for reflection

* fix: format

* fix: add java17-required add-opens=java.base config to native-image.properties

* fix: change add-opens argument to java.base/java.time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@burkedavison @mpeddada1 @kokoro-team