Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): remove unnecessary auto-value in api-common-java #1621

Merged
merged 1 commit into from Apr 11, 2023
Merged

fix(deps): remove unnecessary auto-value in api-common-java #1621

merged 1 commit into from Apr 11, 2023

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Apr 11, 2023 •
edited

Fixes #1618

https://github.com/google/auto/blob/main/value/userguide/index.md#with-maven says

You will need auto-value-annotations-${auto-value.version}.jar in your compile-time classpath, and you will need auto-value-${auto-value.version}.jar in your annotation-processor classpath.

@suztomo suztomo requested a review from a team as a code owner April 11, 2023 17:07
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 11, 2023
BenWhitehead
BenWhitehead reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @suztomo!

@suztomo suztomo mentioned this pull request Apr 11, 2023
Closed
@suztomo suztomo requested a review from lqiu96 April 11, 2023 17:09
@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 11, 2023
@suztomo suztomo merged commit ffeb820 into googleapis:main Apr 11, 2023
19 checks passed
@suztomo suztomo deleted the i1618 branch April 11, 2023 17:47
@release-please release-please bot mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead left review comments

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[api-common]: from v2.3.1 com.google.auto.value:auto-value has compile scope
3 participants
@suztomo @BenWhitehead @lqiu96