Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): add gapic-generator-java to bom #1645

Merged
merged 1 commit into from Apr 21, 2023
Merged

Conversation

emmileaf
Copy link
Contributor

This PR adds gapic-generator-java to the BOM For downstream use in the spring-cloud-gcp generator, per discussion in GoogleCloudPlatform/spring-cloud-gcp#1686 (comment).

(Side note: I'm not sure if this is the right conventional commit prefix to use, vs. chore:?)

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@emmileaf emmileaf marked this pull request as ready for review April 21, 2023 14:14
@emmileaf emmileaf requested a review from a team as a code owner April 21, 2023 14:14
@emmileaf emmileaf added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants