feat: Use gapic-generator-java jar in the client library generation process #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More files removed that are noteworthy: Note:
|
|
|
Sorry for the unintentional pushes to this branch. |
|
Kudos, SonarCloud Quality Gate passed!
|
blakeli0
approved these changes
Jan 6, 2023
lqiu96
added a commit
that referenced
this pull request
Jan 10, 2023
…ary generation process (#918)"" This reverts commit 16d552c8a0225eb6c561eadc67921518c5664544.
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
bdhess
pushed a commit
to GoogleCloudPlatform/kms-integrations
that referenced
this pull request
May 18, 2023
The repository has been renamed to sdk-platform-java, which caused issues with the strip_prefix and the sha256 checksum. In the long term we probably want to look into googleapis/sdk-platform-java#918 and update our dependency accordingly if needed, but for now this should be good enough. Change-Id: I0388c103d7dda729c30d28995517880336ba9d42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note(Updated on 12/29/2022): The description is now almost re-written since a lot of the implementation details changed. Thanks to @chanseokoh who created this PR originally and enlightened me the new approach.
The main goal of this PR is to use the gapic-generator-java jar in the client library generation process, with both released jars and local SNAPSHOT jars. Hence, Bazel will not be used for loading dependencies and building the generator from source going forward. Instead, Maven is now used for building a gapic-generator-jar first, and the jar is passed into the Bazel plugin to generate the client libraries. This PR also removed as much Bazel files/configs as possible.
Nothing changes from the "UI" or "interface" side where how currently outsiders (including googleapis/googleapis) generate GAPIC libraries. The way gapic-generator-java is built is an implementation detail (that changed from Bazel to Maven) and is completely hidden from outsiders.
Local development is almost the same like before, two notable changes:
Next Steps[Must haves]:
dependencies.propertiesfile fromgax-javarepo, which may include different versions from the pom.xml that is used during generation runtime. It is to be determined to find the best way to manage the versions for the generated Gradle files.Next Steps[Nice to haves, not an exhaustive list]:
rules_java_gapicfolder, which is referenced by googleapis in the generation process, hence googleapis will need to dependent on both the jar and the source of gapic-generator-java. We could move these Bazel rules to googleapis so that gapic-generator-java is completely self-contained.