feat: Add add autogenerated javadoc sample for selecting REST transport over gRPC #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt over gRPC This is for grpc+rest clients. Also add proper grpc+rest unit tests which were missing.
product-auto-label
bot
added
the
samples
|
@blakeli0 PTAL |
Neenu1995
reviewed
Apr 21, 2022
| @@ -112,7 +114,10 @@ public static List<CommentStatement> createClassHeaderComments( | |||
| Service service, | |||
| String classMethodSampleCode, | |||
| String credentialsSampleCode, | |||
| String endpointSampleCode) { | |||
| String endpointSampleCode, | |||
| String transportStample, | |||
Neenu1995
approved these changes
Apr 21, 2022
|
Kudos, SonarCloud Quality Gate passed! |
eaball35
reviewed
Apr 22, 2022
| @@ -208,7 +208,10 @@ private static List<CommentStatement> createClassHeaderComments( | |||
| service, | |||
| SampleCodeWriter.writeInlineSample(classMethodSampleCode.body()), | |||
| SampleCodeWriter.writeInlineSample(credentialsSampleCode.body()), | |||
| SampleCodeWriter.writeInlineSample(endpointSampleCode.body())); | |||
| SampleCodeWriter.writeInlineSample(endpointSampleCode.body()), | |||
There was a problem hiding this comment.
do you mean to include these null args?
eaball35
reviewed
Apr 22, 2022
|
|
||
| return ServiceClientCommentComposer.createClassHeaderComments( | ||
| service, | ||
| SampleCodeWriter.writeInlineSample(classMethodSampleCode.body()), |
There was a problem hiding this comment.
You could also combine all the different sample.body into one List and pass the whole list to SampleCodeWriter.writeInlineSample()
eaball35
reviewed
Apr 22, 2022
| Utils.saveCodegenToFile(this.getClass(), "GrpcEchoCallableFactory.golden", visitor.write()); | ||
| Path goldenFilePath = | ||
| Paths.get(Utils.getGoldenDir(this.getClass()), "GrpcEchoCallableFactory.golden"); | ||
| Assert.assertCodeEquals(goldenFilePath, visitor.write()); |
There was a problem hiding this comment.
Consider checking the clazz.samples() as well. See similar grpc tests. See Assert.assertGoldenSamples and assertEmptySamples. Even if there aren't any samples, I think it's good to be clear in the tests which classes generate samples and which don't.
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
…rt over gRPC (#983) This is for grpc+rest clients. Also add proper grpc+rest unit tests which were missing.
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
….12.1 (#983) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.auth:google-auth-library-bom](https://togithub.com/googleapis/google-auth-library-java) | `1.12.0` -> `1.12.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/google-auth-library-java</summary> ### [`v1.12.1`](https://togithub.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#​1121-httpsgithubcomgoogleapisgoogle-auth-library-javacomparev1120v1121-2022-10-18) ##### Bug Fixes - Resolve race condition reported in [#​692](https://togithub.com/googleapis/google-auth-library-java/issues/692) ([#​1031](https://togithub.com/googleapis/google-auth-library-java/issues/1031)) ([87a6606](https://togithub.com/googleapis/google-auth-library-java/commit/87a66067dff49d68f5b01cfe4c3f755fbf6b44fb)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzguNCIsInVwZGF0ZWRJblZlciI6IjMyLjI0MC41In0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for
grpc+restclients.Also add proper
grpc+restunit tests which were missing.