fix: remove PhpFactory::create from PhpClassComparer #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like
ParserFactory::create(..)
is deprecated: refAlso contains following changes to ensure a test pass:
tests/Unit/ProtoTests/*/out/src/Gapic
-> these are files from which generated content is compared.tests/Integration/goldens
-> these are the files from which generated files are compared in integration tests.composer.json
-> needs a php version to be pinned for tests to run, else throws a dependent package min version mismatch errors.tests/Tools/PhpClassComparer.php
-> ensures we mitigate the deprecated old method inParserFactory