fix: more fixes for rest transport #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes:
1) Implicit template support for grpc transcodding (accept `/v1/{project}/stuff` whichis equivalent to `/v1/{project=*}/stuff`)
2) Proper request message construction for paginated methods test
3) Depend on `google-api-core 2.2.0` for rest to accommodate the `int64` support fixes
google-cla
bot
added
the
cla: yes
kbandes
approved these changes
Oct 27, 2021
software-dov
approved these changes
Oct 27, 2021
| @@ -475,6 +475,16 @@ def test_method_http_options_generate_sample(): | |||
| 'id': 'projects/sample1/regions/sample2/id/sample3'}} | |||
|
|
|||
|
|
|||
| def test_method_http_options_generate_sample_immplicit_template(): | |||
There was a problem hiding this comment.
Outrageous nit:
test_method_http_options_generate_sample_implicit_template
busunkim96
approved these changes
Oct 27, 2021
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
/v1/{project}/stuffwhichis equivalent to/v1/{project=*}/stuff)google-api-core 2.2.0for rest to accommodate theint64support fixes