fix: fix rest unit test #1074
Merged
fix: fix rest unit test #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases `hostname:port` format was expected.
google-cla
bot
added
the
cla: yes
alexander-fenster
approved these changes
Nov 5, 2021
tseaver
reviewed
Nov 8, 2021
| @@ -1293,7 +1293,7 @@ def test_{{ method.name|snake_case }}_rest_flattened(transport: str = 'rest'): | |||
| assert len(req.mock_calls) == 1 | |||
| _, args, _ = req.mock_calls[0] | |||
| {% with uri = method.http_options[0].uri %} | |||
| assert path_template.validate("https://{{ service.host }}{{ uri }}", args[1]) | |||
| assert path_template.validate("https://%s{{ uri }}" % client.transport._host, args[1]) | |||
There was a problem hiding this comment.
Do we not have a "golden" example for a REST API?
There was a problem hiding this comment.
No we do not, but I think we should.
There was a problem hiding this comment.
No we do not, but I think it is a good idea to have one.
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases
hostname:portformat was expected.