Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with gapic generator python version 0.58.0 #1102

Closed
parthea opened this issue Dec 9, 2021 · 0 comments · Fixed by #1103
Closed

Issues with gapic generator python version 0.58.0 #1102

parthea opened this issue Dec 9, 2021 · 0 comments · Fixed by #1103
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Dec 9, 2021 •
edited

There are 2 issues with gapic generator python version 0.58.0

  1. A syntax error exists in the generated client for python compute here:

https://github.com/googleapis/python-compute/blob/73df2b5d16f67bf914a72772521003968d7880ac/owl-bot-staging/v1/google/cloud/compute_v1/services/addresses/transports/rest.py#L195-L196

See googleapis/python-compute#168 where owlbot failed to run as a result of the syntax error.

  1. Unused imports were added in many generated clients. For example, see https://github.com/googleapis/python-documentai/pull/251/files
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 9, 2021
@software-dov software-dov linked a pull request Dec 9, 2021 that will close this issue
fix: syntax fix for required_fields struct in rest transport #1103
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: syntax fix for required_fields struct in rest transport software-dov/gapic-generator-python
1 participant
@parthea