Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy nox session fails with types-protobuf 3.19.8 #1180

Closed
parthea opened this issue Feb 2, 2022 · 0 comments · Fixed by #1179
Closed

mypy nox session fails with types-protobuf 3.19.8 #1180

parthea opened this issue Feb 2, 2022 · 0 comments · Fixed by #1179
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Feb 2, 2022

See output here:

Run nox -s mypy
nox > Running session mypy
nox > Creating virtual environment (virtualenv) using python3.9 in .nox/mypy
nox > python -m pip install mypy types-protobuf types-PyYAML types-dataclasses
nox > python -m pip install .
nox > mypy gapic
gapic/schema/api.py:130: error: "FileOptions" has no attribute "Extensions"
gapic/schema/api.py:881: error: "MethodOptions" has no attribute "Extensions"
Found 2 errors in 1 file (checked 35 source files)
nox > Command mypy gapic failed with exit code 1
nox > Session mypy failed.

PR #1179 adds a pin for types-protobuf<=3.19.7 to allow checks to pass so they don't block development.
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 2, 2022
@parthea parthea mentioned this issue Feb 2, 2022
Merged
@software-dov software-dov linked a pull request Feb 2, 2022 that will close this issue
fix(deps): require setuptools<=60.5.0 #1179
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): require setuptools<=60.5.0 googleapis/gapic-generator-python
2 participants
@software-dov @parthea