Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds LRO mixin. #1304

Merged
merged 14 commits into from
May 24, 2022
Merged

feat: adds LRO mixin. #1304

merged 14 commits into from
May 24, 2022

Conversation

atulep
Copy link
Contributor

@atulep atulep commented May 6, 2022 •
edited

Adds support for LRO to existing MixIns implementation. It extends client interface with get_operation, wait_operation, cancel_operation, delete_operation, list_operations methods (if they were defined in service yaml).

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label May 6, 2022
@atulep atulep marked this pull request as ready for review May 14, 2022 03:53
@atulep atulep requested review from a team as code owners May 14, 2022 03:53
@atulep
Copy link
Contributor Author

atulep commented May 14, 2022

@vam-google PTAL

vam-google
vam-google approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check on showcase all 5 new methods (do actual network call) before pushing.

tests/integration/goldens/redis/tests/unit/gapic/redis_v1/test_cloud_redis.py Outdated Show resolved Hide resolved
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot: run labels May 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2022
@atulep atulep merged commit 18af90a into googleapis:main May 24, 2022
@release-please release-please bot mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google vam-google approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atulep @vam-google @parthea