Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add system tests and cert/key #394

Merged
merged 2 commits into from Apr 16, 2020
Merged

Conversation

arithmetic1728
Copy link
Collaborator

@arithmetic1728 arithmetic1728 commented Apr 15, 2020

  1. added testing cert/key for mtls system test (expired after 1000 years, CN=localhost). cert can also be used as root ca cert since it is self signed.
  2. we will reuse all the system tests we have now. Introduced a --mtls flag to change all the channels to mtls channels, and added separated nox sessions.
  3. since the generated client doesn't take root ca cert (only takes cert and key), we need to mock grpc.grpc.ssl_channel_credentials, assert it is called with the correct cert/key, but return the channel created with root ca cert, cert and key.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2020
@arithmetic1728 arithmetic1728 marked this pull request as draft April 15, 2020 21:15
@arithmetic1728 arithmetic1728 marked this pull request as ready for review April 16, 2020 21:52
Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clever and straightforward. Excellent job.

One minor judgement call nit

tests/system/conftest.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants