fix: remove client recv msg limit #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
changed the title
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1598 1598
Branches 324 324
=========================================
Hits 1598 1598 Continue to review full report at Codecov.
|
busunkim96
commented
Dec 10, 2020
| @@ -101,6 +101,10 @@ class {{ service.name }}RestTransport({{ service.name }}Transport): | |||
| self._host, | |||
| credentials=self._credentials, | |||
| scopes=self.AUTH_SCOPES, | |||
| options=[ | |||
There was a problem hiding this comment.
I added the options wherever a channel was created, but am not 100% sure if it makes sense here (in the rest transport). @yon-mg could you take a look?
software-dov
approved these changes
Dec 10, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #669
Replicates change made in monolithic generator to remove client side size limits.
googleapis/gapic-generator#2900 googleapis/gapic-generator#2905