Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix rest transport tests #772

Merged
merged 2 commits into from Feb 10, 2021
Merged

Conversation

vam-google
Copy link
Contributor

This includes fix fo data vs json parameter issue and the enum serialization (string instead of number) issue.

This includes fix fo `data` vs `json` parameter issue and the enum serialization (string instead of number) issue.
@vam-google vam-google requested a review from a team as a code owner February 10, 2021 01:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #772 (8431a8a) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #772   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1623   +15     
  Branches       328       330    +2     
=========================================
+ Hits          1608      1623   +15     
Impacted Files Coverage Δ
gapic/utils/case.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
gapic/utils/checks.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7379321...8431a8a. Read the comment docs.

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 10, 2021
@busunkim96 busunkim96 merged commit ce110a3 into googleapis:master Feb 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants