fix: use correct retry deadline in publisher methods #814
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1653 +45
Branches 328 337 +9
=========================================
+ Hits 1608 1653 +45
Continue to review full report at Codecov.
|
|
Done, and the same for the async client template, PTAL. BTW, for future reference, what are |
|
For really frustrating, annoying reasons, the Ads team has special requirements for their GAPIC; the easiest solution is to just have a separate, mostly identical set of templates for them. The big difference that they required has to do with multiple version subdirectories. ads wants something like: It also makes it easier to support their lazy load feature, which requires python 3.7, but the other gapics must support 3.6. |
🤖 I have created a release \*beep\* \*boop\* --- ### [0.43.1](https://www.github.com/googleapis/gapic-generator-python/compare/v0.43.0...v0.43.1) (2021-03-19) ### Bug Fixes * use correct retry deadline in publisher methods ([#814](https://www.github.com/googleapis/gapic-generator-python/issues/814)) ([92a2cfc](https://www.github.com/googleapis/gapic-generator-python/commit/92a2cfc47b24c4b1a041d5bbb944d69a67a962a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes #794.
This PR makes sure that correct Retry deadline is used in publisher methods. Should fix googleapis/python-pubsub#303 when the Python PubSub code is re-generated.