Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: samplegen always produces sample dicts with "response" #914

Merged
merged 11 commits into from Jun 9, 2021
Merged

fix: samplegen always produces sample dicts with "response" #914

merged 11 commits into from Jun 9, 2021
+2,826 −17

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jun 8, 2021 •
edited

  • fix samplegen logic to always set a sample[response]
  • enable autogen-snippets for the golden integration tests that are run through Bazel
  • install some extra stub packages for mypy that are needed with the new release

@busunkim96 busunkim96 requested a review from a team as a code owner June 8, 2021 20:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jun 8, 2021 •
edited

Here is the summary of changes.

You are about to add 59 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited

Codecov Report

Merging #914 (3467591) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #914   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1698   +90     
  Branches       328       347   +19     
=========================================
+ Hits          1608      1698   +90
Impacted Files Coverage Δ
gapic/samplegen_utils/types.py 100.00% <ø> (ø)
gapic/samplegen_utils/utils.py 100.00% <ø> (ø)
gapic/utils/case.py 100.00% <ø> (ø)
gapic/utils/reserved_names.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/samplegen/samplegen.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
gapic/schema/metadata.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5225b67...3467591. Read the comment docs.

@busunkim96 busunkim96 closed this Jun 8, 2021
@busunkim96 busunkim96 reopened this Jun 8, 2021
@busunkim96 busunkim96 changed the title test: generate snippets for golden integration tests fix: samplegen always produces sample dicts with "response" Jun 8, 2021
@busunkim96 busunkim96 requested a review from parthea June 8, 2021 23:58
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 9, 2021
@busunkim96 busunkim96 merged commit 0b168f2 into master Jun 9, 2021
@busunkim96 busunkim96 deleted the add-snippets-to-golden branch June 9, 2021 17:08
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 9, 2021
@release-please
chore: release 0.48.1 (#916)
25aa8c9 
🤖 I have created a release \*beep\* \*boop\*
---
### [0.48.1](https://www.github.com/googleapis/gapic-generator-python/compare/v0.48.0...v0.48.1) (2021-06-09)


### Bug Fixes

* samplegen always produces sample dicts with "response" ([#914](https://www.github.com/googleapis/gapic-generator-python/issues/914)) ([0b168f2](https://www.github.com/googleapis/gapic-generator-python/commit/0b168f20f4cbf419131fcc512141fccca8186681))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 18, 2022
Merged
Closed
Closed
This was referenced Jan 26, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@busunkim96 @parthea