Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GAPIC Error classes #207

Closed
blowmage opened this issue Aug 12, 2019 · 2 comments
Closed

Remove GAPIC Error classes #207

blowmage opened this issue Aug 12, 2019 · 2 comments
Assignees
@blowmage
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
Cloud

Comments

@blowmage
Copy link
Contributor

The gapic-common error classes that wrap GRPC::BadStatus can be removed once the GPRC errors can be loaded without loading the GRPC C library. Once grpc/grpc#19893 has been released the GAPIC error classes can be removed.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Aug 13, 2019
@jbolinger jbolinger added this to To do in Cloud Aug 14, 2019
@blowmage blowmage self-assigned this Aug 14, 2019
@blowmage
Copy link
Contributor Author

We have grpc changes to allow for this (grpc/grpc#19893 and grpc/grpc#19939), and they look like they won't be released until grpc version 1.24.0.

@blowmage blowmage added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Aug 14, 2019
@dazuma
Copy link
Member

dazuma commented Jan 1, 2020

This looks done.

@dazuma dazuma closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blowmage blowmage

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
Cloud
  
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blowmage @dazuma @yoshi-automation