Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Expose ability to close GRPC channels #68

Closed
schmidt-sebastian opened this issue Oct 23, 2019 · 6 comments · Fixed by #126
Closed

Node: Expose ability to close GRPC channels #68

schmidt-sebastian opened this issue Oct 23, 2019 · 6 comments · Fixed by #126
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@schmidt-sebastian
Copy link
Contributor

The Firestore Server SDK can initiate multiple clients if more than 100 requests are active. Especially for users that frequently create and destroy clients, this creates memory leaks as we are unable to close GRPC channels on destruction.

Would it be possible to expose a "close" API to the Node Veneer SDKs?

This would unblock googleapis/nodejs-firestore#779 and googleapis/nodejs-firestore#769

@alexander-fenster @thebrianchen

@busunkim96
Copy link

👋 Was this issue intended for another repo?

@schmidt-sebastian
Copy link
Contributor Author

I was hoping this is the right repo. Can you tell me where the code lives that turns the Protos into the auto-generated clients that most GCloud libraries depend on?

@JustinBeckwith JustinBeckwith transferred this issue from googleapis/synthtool Oct 24, 2019
@JustinBeckwith JustinBeckwith added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 24, 2019
@busunkim96
Copy link

The generator lives in https://github.com/googleapis/gapic-generator/. @bcoe and @alexander-fenster could you help route this?

@busunkim96
Copy link

Ah I see it's already been moved, never mind! 🤦‍♀️

@merlinnot
Copy link

@alexander-fenster @schmidt-sebastian Hey guys, maybe we could align in this thread on the design for the API, so I could make a PR? It's very impactful for my company because of the Firestore memory leak and I'd be glad to help fixing it.

@schmidt-sebastian
Copy link
Contributor Author

I will work on this next week. Please do bug me regularly for updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants