-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: Expose ability to close GRPC channels #68
Comments
👋 Was this issue intended for another repo? |
I was hoping this is the right repo. Can you tell me where the code lives that turns the Protos into the auto-generated clients that most GCloud libraries depend on? |
The generator lives in https://github.com/googleapis/gapic-generator/. @bcoe and @alexander-fenster could you help route this? |
Ah I see it's already been moved, never mind! 🤦♀️ |
@alexander-fenster @schmidt-sebastian Hey guys, maybe we could align in this thread on the design for the API, so I could make a PR? It's very impactful for my company because of the Firestore memory leak and I'd be glad to help fixing it. |
I will work on this next week. Please do bug me regularly for updates. |
The Firestore Server SDK can initiate multiple clients if more than 100 requests are active. Especially for users that frequently create and destroy clients, this creates memory leaks as we are unable to close GRPC channels on destruction.
Would it be possible to expose a "close" API to the Node Veneer SDKs?
This would unblock googleapis/nodejs-firestore#779 and googleapis/nodejs-firestore#769
@alexander-fenster @thebrianchen
The text was updated successfully, but these errors were encountered: