Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Document default settings #197

Closed
geigerj opened this issue Jun 7, 2016 · 5 comments
Closed

Document default settings #197

geigerj opened this issue Jun 7, 2016 · 5 comments
Assignees
Labels
lang: nodejs Issues specific to JavaScript or TypeScript. lang: php Issues specific to PHP. lang: python Issues specific to Python. lang: ruby Issues specific to Ruby. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@geigerj
Copy link
Contributor

geigerj commented Jun 7, 2016

The default settings (as stored in the client config JSON) should also appear in the documentation.

Proposal: use the GAPIC config to generate a reST file that Sphinx can incorporate into the generated docs (or equivalent for other languages).

@bjwatson
Copy link
Contributor

bjwatson commented Jun 20, 2016

Copied from googleapis/gax-python#106:

During the usability study, participants intuitively understood the role of the CallOptions parameter, and its implications on their API requests.

However, for those that investigated further, it was not clear what the default CallOptions setting were, and thus it was difficult to predict the behavior of their requests without first manually setting the options.

Recommendation: Ensure that default CallOptions are accurately and clearly documented. If default options differ by API request, consider adding the defaults to each method’s reference documentation, so user can accurately predict the behavior of their request.

/cc @omaray
/cc @andrewmacvean
/cc @tbetbetbe

@bjwatson bjwatson added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Aug 9, 2016
@bjwatson bjwatson added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 19, 2016
@eoogbe eoogbe added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Aug 11, 2017
@eoogbe
Copy link
Contributor

eoogbe commented Aug 17, 2017

@geigerj Is this still relevant?

@geigerj
Copy link
Contributor Author

geigerj commented Aug 17, 2017

Yes, AFAIK we still don't document the default method configuration in any of the GAPIC docs.

@geigerj geigerj removed their assignment Aug 17, 2017
@geigerj
Copy link
Contributor Author

geigerj commented Aug 17, 2017

Unassigning to go back on the backlog -- I'm not going to have bandwidth for this in the near future.

@geigerj geigerj changed the title Python: Document default settings Document default settings Aug 17, 2017
@geigerj geigerj added lang: nodejs Issues specific to JavaScript or TypeScript. lang: php Issues specific to PHP. lang: ruby Issues specific to Ruby. labels Aug 17, 2017
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Jun 27, 2019
@sduskis sduskis removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 3, 2019
@yihanzhen yihanzhen added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 9, 2020
@miraleung miraleung self-assigned this Jun 3, 2020
@hkdevandla
Copy link
Member

Obsolete since this doesn't look like relevant and seems very old feature request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang: nodejs Issues specific to JavaScript or TypeScript. lang: php Issues specific to PHP. lang: python Issues specific to Python. lang: ruby Issues specific to Ruby. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

10 participants