Potential bug in tests for testing headers and trailers #1499
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
The check below fails because of 2 issues. Incorrect expected values, and incorrect boolean comparison
gapic-showcase/server/services/echo_service_test.go
Lines 125 to 127 in 961e217
"showcaseHeader, anotherHeader"
instead of"showcaseHeader", "anotherHeader"
&&
in the boolean check for verifying the value of both headers and trailers. It should be||
so that if either check for headers or trailers fails, we get an error condition.The way it is written now
NOT <condition> && NOT <condition>
-> both conditions must be false for the error condition to appearThe way it should be
NOT <condition> || NOT <condition>
-> only one condition should be false for the error condition to appearThe text was updated successfully, but these errors were encountered: