This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32ad33f
to
529ee1f
Compare
Linkage Monitor checks linkage errors in the following step:
Because GAX 1.67.1-SNAPSHOT uses a new method in google-auth-library-oauth2-http 0.27.0. It's a new linkage error. I'm thinking how to resolve this. (GoogleCloudPlatform/cloud-opensource-java#2137) For now, it requires a new release of the shared dependencies BOM and the Libraries BOM before merging this change. |
Added |
TimurSadykov
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
miraleung
approved these changes
Aug 3, 2021
I just released a new version of the Libraries BOM that contains the auth library 1.0.0. It may take time (few hours) for Maven to show it as the latest version. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 16, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.3.0](https://www.github.com/googleapis/gax-java/compare/v2.2.0...v2.3.0) (2021-08-16) ### Features * add custom options to ApiCallContext ([#1435](https://www.github.com/googleapis/gax-java/issues/1435)) ([0fe20f3](https://www.github.com/googleapis/gax-java/commit/0fe20f379feba1570e562e60e3f0bf7cc4e485bd)) * add UseJwtAccessWithScope to GoogleCredentialsProvider ([#1420](https://www.github.com/googleapis/gax-java/issues/1420)) ([ed39c34](https://www.github.com/googleapis/gax-java/commit/ed39c34693783460fc03effb47e7027914cfb5bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
UseJwtAccessWithScope
property toGoogleCredentialsProvider
, which passes the property value toServiceAccountCredentials
to trigger self signed JWT.This property will be set by GAPIC clients, example PR: arithmetic1728/java-kms#3