This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
fix: update the runtime dependency grpc-java xds to googleapis #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
Mar 31, 2022
| @@ -39,7 +39,7 @@ ext { | |||
| 'maven.io_grpc_grpc_protobuf': "io.grpc:grpc-protobuf:${libraries['version.io_grpc']}", | |||
| 'maven.io_grpc_grpc_netty_shaded': "io.grpc:grpc-netty-shaded:${libraries['version.io_grpc']}", | |||
| 'maven.io_grpc_grpc_alts': "io.grpc:grpc-alts:${libraries['version.io_grpc']}", | |||
| 'maven.io_grpc_grpc_xds': "io.grpc:grpc-xds:${libraries['version.io_grpc']}", | |||
There was a problem hiding this comment.
Do we want to remove the code references to xds as well? Like this variable name?
There was a problem hiding this comment.
We still need this variable to protect the migration, and there is no need to change the variable name as xds protocol is still used.
blakeli0
approved these changes
Mar 31, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In grpc/grpc-java#8963, the
google-c2p-experimentalname resolver is moved from xds package to googleapis package in grpc java, so we need to update the runtime dependency accordingly.cc @ejona86