-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing dependency request causes an error when using Google Cloud's Vision API #1606
Comments
Also facing this issue when using ^6.4.0 of @google-cloud/language w/Next.js |
@google-cloud/compute with nextjs is having the same issue |
Faced the same issue while using firebase with nodeJs |
Apologies for the closure, reopen, re closure. Some more info: Part of retry-request functionality has been migrated into gax with the goal of not needing to depend on retry-request at all in a future major version. Until #1612, we also had that extremely outdated I just verified, and vision depends on a version of gax where this has since been fixed, as do the latest versions of google-cloud-language |
Hi @leahecole, I'm using the latest version of @google-cloud/language (6.4.0) and this issue is still present. Are you saying in future releases it'll include your #1612 fix and we won't have to keep request as a dependency anymore? |
Hi @jahabeebs thank you for the update, good to know! Yes, the next release when we cut it should include #1612, and our automation should push that out to client libraries soon - I'll poke some folks for reviews today to make sure everything is okay with cutting that release hopefully today. Request shouldn't have to be a dependency once that happens especially given that that outdated line of code is removed from the version of retry-request found in gax already. |
Environment details
google-gax
version: 2.28.0Steps to reproduce
serverless
Node.js projectserverless-webpack
plugin to yourserverless.yml
file and usewebpack
withbabel
to package the function that will be created@google-cloud/vision
as a dependencyHere's an example YML configuration file for a Lambda that uses this:
Error
Possible solution
Add the package
request
as a dependency of the project here given you've includedretry-request
Workaround
Add
request
as a dependency of the serverless project by runningnpm install request --save
Also: Issue #1149 was closed for no good reason and we had lots of further comments of people with the same bug.
The
request
library has reached end of life so the ideal solution would be to get rid of it completely in this project.The text was updated successfully, but these errors were encountered: