Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 2.1.0 release never got published to npm #177

Closed
JustinBeckwith opened this issue Oct 18, 2019 · 8 comments
Closed

The 2.1.0 release never got published to npm #177

JustinBeckwith opened this issue Oct 18, 2019 · 8 comments
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@JustinBeckwith
Copy link
Contributor

Looking here:
#174

It looks like 2.1.0 never went out, despite the GitHub Release getting created. This bug is to unstick this release.

To track the overall problem:
googleapis/releasetool#229

@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 18, 2019
@AaronFriel
Copy link

What's the ETA on deploying this? Any indirect consumers using npm audit as part of their release process is blocked on builds.

@bcoe
Copy link
Contributor

bcoe commented Oct 18, 2019

@AaronFriel please try this out npm i gaxios@2.1.0, just released it manually, since we didn't quite have things setup for automation yet.

@IlleQuiProgrammat
Copy link

I just tested it and can confirm it works--came here after noticing it was using a vulnerable version of https-proxy-agent. Thanks, @JustinBeckwith i think this can be closed now?

@AaronFriel
Copy link

🙌 thank you! npm audit fix is still not picking up the resolution path (not sure what algorithm it uses), but manually installing gaxios@2.1.0 resulted in npm audit passing.

Anyone using packages such as @google-cloud/kms may need to perform the same resolution steps.

@JustinBeckwith
Copy link
Contributor Author

Oh weird - can you try deleting your package-lock.json and node_modules and running npm install again? With a clean install I'm seeing:

nodejs-kms (master) $ npm ls --production gaxios
@google-cloud/kms@1.5.0 /Users/beckwith/Code/nodejs-kms
└─┬ google-gax@1.7.5
  └─┬ google-auth-library@5.5.0
    ├── gaxios@2.1.0 
    ├─┬ gcp-metadata@3.2.0
    │ └── gaxios@2.1.0  deduped
    └─┬ gtoken@4.1.0
      └── gaxios@2.1.0  deduped

@IlleQuiProgrammat
Copy link

It might be their server caching the value perhaps and only when it was specifically requested did they look it up---like DNS servers I suppose.

@AaronFriel
Copy link

@JustinBeckwith I reverted back to the commit that was failing npm audit and ran npm audit fix again and it resolved automatically. Looks like you're right about some caching involved.

@bcoe
Copy link
Contributor

bcoe commented Oct 18, 2019

sounds like this is resolved, let us know if you bump into any more issues 👍

@bcoe bcoe closed this as completed Oct 18, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

5 participants