Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: drop node 10 from engines list, update typescript to 4.6.3 #477

Merged
merged 3 commits into from Apr 19, 2022

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 6, 2022
@generated-files-bot
Copy link

generated-files-bot bot commented Apr 6, 2022

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@ddelgrosso1
Copy link
Contributor Author

There are a bunch of Kokoro files still referencing Node 8 and Node 10. Can these be safely updated?

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@ddelgrosso1 ddelgrosso1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 7, 2022
@@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 14, 16]
node: [12, 14, 16]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OwlBot seems upset that I touched this. Should I have left this alone?

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 15, 2022
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review April 15, 2022 14:40
@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner April 15, 2022 14:40
@ddelgrosso1 ddelgrosso1 requested a review from sofisl April 15, 2022 14:40
@ddelgrosso1 ddelgrosso1 changed the title feat!: drop node 10 from engines list, update typescript to 4.6.3 build!: drop node 10 from engines list, update typescript to 4.6.3 Apr 15, 2022
@sofisl
Copy link
Contributor

sofisl commented Apr 18, 2022

@ddelgrosso1, everything looks good here except that the post-processor doesn't seem to be picking up the new ci.yaml file. It should look like: node: [12, 14, 16] and the SRS file should be testing 12, 14, and 16, since we're dropping Node 10 now. I wonder if the force-push perhaps overwrote what the post-processor should have done, would you mind attempting to re-push to see if the postprocessor runs? You can also attempt to run the script that I wrote in a new branch if that doesn't work, should be the same changes you've already made.

@sofisl
Copy link
Contributor

sofisl commented Apr 18, 2022

The other question I have is for @bcoe, should these be build! or feat!

@ddelgrosso1
Copy link
Contributor Author

@sofisl the reason the post processor didn't run is because I work from my own fork. I always have to manually trigger it. I've updated the 2 .yml files you called out.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2022
@bcoe bcoe merged commit a926962 into googleapis:main Apr 19, 2022
@ddelgrosso1 ddelgrosso1 deleted the node-12 branch April 19, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants