Fix primitive extensions issues #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being a yaml.mapslice
In case of extension of primitive types (int, string etc.), they are not of type mapslice. a general interface {} type just works fine for our purpose.
For primitive extension, we cannot unmarshal to yaml.mapslice. Therefore, unmarshaling of yamlString has to happen per extension.
…ct to the individual extension handlers. Last commit 854416b should have included this change, accidentally missed it.
timburks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto generate extensions for primitive types of extension schema.
Extensions are represented google.protobuf.Any type. But Any types can only represent Message types within them. Therefore we will need to use wrapper types to convert primitives into google.protobuf.Any when reading an extension of type int/string etc.
Please look at the examples on how to declare extensions of primitive types.