fix(deps): update all modules #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
approved these changes
Aug 9, 2022
| @@ -8,7 +8,7 @@ jobs: | |||
| test: | |||
| strategy: | |||
| matrix: | |||
| go-version: [1.15.x, 1.16.x] | |||
| go-version: [1.15.x, 1.18.x] | |||
There was a problem hiding this comment.
I think we require go 1.17 as the minimum, so would it not make more sense to test with 1.17 and 1.18 here?
There was a problem hiding this comment.
I tried making it work similar to https://github.com/googleapis/google-cloud-go/blob/main/spanner/go.mod#L3, In client library too we do test with earliest(1.15) and latest(1.18) Go versions on each presubmit.
There was a problem hiding this comment.
But why is 1.15 earliest in this case? Aren't the other updates in this PR setting the minimum required version of Go to 1.17?
There was a problem hiding this comment.
as outlined here https://cloud.google.com/go/getting-started/supported-go-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.