feat: support of uint for gorm.Model #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
reviewed
Oct 25, 2023
driver.go
Outdated
| @@ -723,6 +723,7 @@ func checkIsValidType(v driver.Value) bool { | |||
| default: | |||
| return false | |||
| case nil: | |||
| case uint: | |||
There was a problem hiding this comment.
nit: move this down to line 741 and also include support for []uint and *uint if possible.
rahul2393
force-pushed
the
support_gorm_model
branch
from
672d406
to
51f013b
Compare
harshachinta
approved these changes
Oct 30, 2023
olavloite
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gorm.io/docs/models.html#gorm-Model declares field ID type uint for gorm, this PR will enable use of uint datatype with spanner driver