fix: always set a value for dest in Next #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Next method should **always** set a value for each dest[i] element, even when it is nil, as the sql package reuses the same array for multiple calls to Next. This means that the previous value would be returned if the in some cases when the database value was NULL.
google-cla
bot
added
the
cla: yes
hengfengli
reviewed
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Next method should always set a value for each dest[i] element, even when it is nil, as the sql package reuses the same array for multiple calls to Next. This means that the previous value would be returned if the in some cases when the database value was NULL.