Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refuse DDL during transactions #41

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Conversation

olavloite
Copy link
Collaborator

DDL statements cannot be executed as part of a transaction on Cloud Spanner.
Although it would be technically possible to execute a DDL statement while a
transaction is active, it could cause confusion whether the statement is part
of the transaction or not. The driver therefore should return an error if an
application tries to execute a DDL statement during an active transaction.

Fixes #31

DDL statements cannot be executed as part of a transaction on Cloud Spanner.
Although it would be technically possible to execute a DDL statement while a
transaction is active, it could cause confusion whether the statement is part
of the transaction or not. The driver therefore should return an error if an
application tries to execute a DDL statement during an active transaction.

Fixes #31
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2021
Copy link
Collaborator

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@olavloite olavloite merged commit 4e7fa97 into main Sep 17, 2021
@olavloite olavloite deleted the refuse-ddl-in-transaction branch September 17, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: Allow DDL statements in transactions?
2 participants