feat: add support for stale reads #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
hengfengli
reviewed
Oct 11, 2021
hengfengli
reviewed
Oct 11, 2021
hengfengli
reviewed
Oct 11, 2021
examples/stale-reads/main.go
Outdated
| } | ||
| fmt.Printf("Singers count at timestamp %s was: %v\n", t.Format(time.RFC3339Nano), c) | ||
|
|
||
| // Commit the read-only transaction and close the connection to release the resources they areß using. |
There was a problem hiding this comment.
Nits: remove the weird char in areß.
hengfengli
reviewed
Oct 11, 2021
| fmt.Printf("Singers count at timestamp %s was: %v\n", t.Format(time.RFC3339Nano), c) | ||
|
|
||
| // Commit the read-only transaction and close the connection to release the resources they areß using. | ||
| if err := tx.Commit(); err != nil { |
There was a problem hiding this comment.
Just curious: why do we need to call Commit on a read-only txn?
There was a problem hiding this comment.
We need to indicate when we are done with a read-only transaction so the underlying session can be returned to the session pool, and the go-sql Transaction interface does not have anything like a Close method. So both the Commit and Rollback methods of Transaction do the same for read-only transactions; they return the underlying session to the pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for setting a read-only staleness for both single reads and multi-use read-only transactions.