feat(transport): add an env variable to disable DirectPath #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohanli-ml is this a part of any AIP? I think any envvar related to auth needs to be well documented for our users. Is there a plan for this? |
|
@codyoss Sorry we do not have a doc. The environment variable is not used for auth, its purpose is to provide service owners a more granular control of DirectPath. For now we use GCP project number ACL to control directPath, but we meet the situation where the same VM runs both CFE and DP probers. In this case ACL is not enough, and we need a more granular control. Only when this environment variable be set to "true" will DirectPath be disabled, otherwise the logic is the same as current. |
codyoss
approved these changes
Feb 18, 2022
|
Sure. Could you help to merge this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an environment variable
GOOGLE_CLOUD_DISABLE_DIRECT_PATHto disable DirectPath. We expect users to use the EnableDirectPath option to control DirectPath for most cases, and this environment variable is for special cases like running both DP and GFE traffic on the same VM. As a result, only when this env variable is explicitly set totruewill DirectPath be disabled.Same PR for Java: googleapis/gax-java#1412.