Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add response headers to Error reported by CheckMediaResponse #1769

Closed
BrennaEpp opened this issue Dec 6, 2022 · 1 comment · Fixed by #1781
Closed

add response headers to Error reported by CheckMediaResponse #1769

BrennaEpp opened this issue Dec 6, 2022 · 1 comment · Fixed by #1781
Assignees
@codyoss
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@BrennaEpp
Copy link
Contributor

We add them to the CheckResponse function.

Would it be reasonable to add them to the CheckMediaResponse function too? This would allow us to surface them to the user on googleapi read errors in the Storage library through apiary.
@BrennaEpp BrennaEpp added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Dec 6, 2022
@codyoss
Copy link
Member

codyoss commented Dec 6, 2022

Seems reasonable to me. Feel free to make a PR

@BrennaEpp BrennaEpp mentioned this issue Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@codyoss @BrennaEpp