Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve error handling for enterprise certificate module #1848

Merged
merged 2 commits into from Feb 10, 2023

Conversation

andyrzhao
Copy link
Contributor

ECP client now returns a typed error to cover all situations where ECP config is unavailable or incomplete.

@andyrzhao andyrzhao requested review from a team and yoshi-approver as code owners February 8, 2023 22:38
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Feb 10, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3fb5b61 into googleapis:main Feb 10, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 10, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 13, 2023
🤖 I have created a release *beep* *boop*
---


## [0.110.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.109.0...v0.110.0) (2023-02-13)


### Features

* **all:** Auto-regenerate discovery clients ([#1838](https://togithub.com/googleapis/google-api-go-client/issues/1838)) ([4b4c9d4](https://togithub.com/googleapis/google-api-go-client/commit/4b4c9d468a78cae7a41cbcb14054999dfef31b80))
* **all:** Auto-regenerate discovery clients ([#1841](https://togithub.com/googleapis/google-api-go-client/issues/1841)) ([3fb8cdc](https://togithub.com/googleapis/google-api-go-client/commit/3fb8cdc9c2ddf336497bc36fd06fab43b2235d06))
* **all:** Auto-regenerate discovery clients ([#1850](https://togithub.com/googleapis/google-api-go-client/issues/1850)) ([8980266](https://togithub.com/googleapis/google-api-go-client/commit/89802661d011ff33e3d5988f0e894702eba9c009))
* **all:** Auto-regenerate discovery clients ([#1851](https://togithub.com/googleapis/google-api-go-client/issues/1851)) ([689f934](https://togithub.com/googleapis/google-api-go-client/commit/689f934fca8cc3f8be521e41ab1e270691441dde))


### Bug Fixes

* Improve error handling for enterprise certificate module ([#1848](https://togithub.com/googleapis/google-api-go-client/issues/1848)) ([3fb5b61](https://togithub.com/googleapis/google-api-go-client/commit/3fb5b6154399e00f030db5570673f4690c534ddf))
* **internal/gensupport:** Don't prematurely close timers ([#1856](https://togithub.com/googleapis/google-api-go-client/issues/1856)) ([8efd00d](https://togithub.com/googleapis/google-api-go-client/commit/8efd00d3a913d1c454622791d4bfaa23e1343d70))
* Update ECP dependency to v0.2.3 ([#1857](https://togithub.com/googleapis/google-api-go-client/issues/1857)) ([1147cb8](https://togithub.com/googleapis/google-api-go-client/commit/1147cb8a93dfcd0255280b43a7f011ac2cf6ddab))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants