fix(internal/gensuport): don't prematurely close timers #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quitAfterTimer should only be closed when function breaks or returns as it is created outside of the for loop. Tested with local replacing and fixes failing TestIndefiniteRetries test with the patch. Fixes: googleapis/google-cloud-go#7410
codyoss
changed the title
tritone
approved these changes
Feb 13, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.110.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.109.0...v0.110.0) (2023-02-13) ### Features * **all:** Auto-regenerate discovery clients ([#1838](https://togithub.com/googleapis/google-api-go-client/issues/1838)) ([4b4c9d4](https://togithub.com/googleapis/google-api-go-client/commit/4b4c9d468a78cae7a41cbcb14054999dfef31b80)) * **all:** Auto-regenerate discovery clients ([#1841](https://togithub.com/googleapis/google-api-go-client/issues/1841)) ([3fb8cdc](https://togithub.com/googleapis/google-api-go-client/commit/3fb8cdc9c2ddf336497bc36fd06fab43b2235d06)) * **all:** Auto-regenerate discovery clients ([#1850](https://togithub.com/googleapis/google-api-go-client/issues/1850)) ([8980266](https://togithub.com/googleapis/google-api-go-client/commit/89802661d011ff33e3d5988f0e894702eba9c009)) * **all:** Auto-regenerate discovery clients ([#1851](https://togithub.com/googleapis/google-api-go-client/issues/1851)) ([689f934](https://togithub.com/googleapis/google-api-go-client/commit/689f934fca8cc3f8be521e41ab1e270691441dde)) ### Bug Fixes * Improve error handling for enterprise certificate module ([#1848](https://togithub.com/googleapis/google-api-go-client/issues/1848)) ([3fb5b61](https://togithub.com/googleapis/google-api-go-client/commit/3fb5b6154399e00f030db5570673f4690c534ddf)) * **internal/gensupport:** Don't prematurely close timers ([#1856](https://togithub.com/googleapis/google-api-go-client/issues/1856)) ([8efd00d](https://togithub.com/googleapis/google-api-go-client/commit/8efd00d3a913d1c454622791d4bfaa23e1343d70)) * Update ECP dependency to v0.2.3 ([#1857](https://togithub.com/googleapis/google-api-go-client/issues/1857)) ([1147cb8](https://togithub.com/googleapis/google-api-go-client/commit/1147cb8a93dfcd0255280b43a7f011ac2cf6ddab)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quitAfterTimer should only be closed when function breaks or returns as it is created outside of the for loop. Tested with local replacing and fixes failing TestIndefiniteRetries test with the patch.
Fixes: googleapis/google-cloud-go#7410