feat(idtoken): add support for external_account #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senthilkumarkj
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
JFYI, below is the test file I used to test with both |
codyoss
approved these changes
Mar 13, 2023
codyoss
added
the
kokoro:force-run
codyoss
changed the title
kokoro-team
removed
the
kokoro:force-run
codyoss
reviewed
Mar 13, 2023
added 2 commits
March 13, 2023 12:42
* Also fix a bug for impersonated_service_account
* When creds are passed with WithCredentialsFile(), it doesn't work.
* Pass the option when creating the token source.
* Fixes PR googleapis#1879
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
external_accounttype (Workload Identity Federation) #1879