Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible NPE calculating X-Goog-Api-Client header #1209

Closed
chingor13 opened this issue Oct 29, 2018 · 0 comments
Closed

Possible NPE calculating X-Goog-Api-Client header #1209

chingor13 opened this issue Oct 29, 2018 · 0 comments
Assignees
@chingor13
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Collaborator

Environment details

  • OS: none (GAE standard 7)
  • Java version: 7
  • google-api-java-client version: 1.26.0

Steps to reproduce

  1. GAE Standard Java 7 (deprecated) may not set the os.version System property and could cause a NPE.

External references such as API reference guides used

google-api-java-client/google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java

Line 141 in 1207585

private static final String OS_VERSION = formatSemver(System.getProperty("os.version"));

@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 29, 2018
@chingor13 chingor13 mentioned this issue Oct 29, 2018
Merged
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Oct 30, 2018
@chingor13 chingor13 self-assigned this Oct 30, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chingor13 @JustinBeckwith