Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Blocking I/O in MtlsUtils #2298

Open
blakeli0 opened this issue Apr 25, 2023 · 0 comments
Open

Refactor Blocking I/O in MtlsUtils #2298

blakeli0 opened this issue Apr 25, 2023 · 0 comments
Assignees
@TimurSadykov
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@blakeli0
Copy link
Contributor

There is a the Boq violation for MtlsUtils regarding blocking I/O when we try to migrate this repo to google3.
Even though it is not required to not having blocking I/O on Github and the code looks reasonable, we also try to avoid process spawning and blocking I/O.
Per @TimurSadykov, this code path also has a narrow use case so it may not be worth it to refactor it. Assigning to @TimurSadykov for further triaging and prioritizing.
@blakeli0 blakeli0 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 25, 2023
@alicejli alicejli added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimurSadykov TimurSadykov

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TimurSadykov @blakeli0 @alicejli