Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drive API samples don't state Node version requirement #1461

Closed
MIchaelMainer opened this issue Nov 26, 2018 · 0 comments
Closed

Drive API samples don't state Node version requirement #1461

MIchaelMainer opened this issue Nov 26, 2018 · 0 comments
Assignees
@JustinBeckwith
Labels
type: docs Improvement to the documentation for an API.

Comments

@MIchaelMainer
Copy link
Contributor

https://github.com/googleapis/google-api-nodejs-client/tree/master/samples/drive

Environment details

  • OS: Mac 10.14.1
  • Node.js version: 6.9.5
  • npm version: 6.4.1
  • googleapis version: v3

Steps to reproduce

  1. Run samples besides the quickstart.js.
  2. Get an error about function being an unknown token.

Solution

Provide customers with a statement about requiring Node 8+ as it has support for async await. This will be helpful for those of us that don't use Node regularly.
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Nov 27, 2018
@AVaksman AVaksman mentioned this issue Nov 29, 2018
Merged
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. type: docs Improvement to the documentation for an API. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Dec 1, 2018
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JustinBeckwith @MIchaelMainer