-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enforce Locale.US for AwsRequestSignerTest #1111
fix: Enforce Locale.US for AwsRequestSignerTest #1111
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
9b34c47
to
df69c70
Compare
Date parsing can fail in other locales. Specifically, in `en-CA` (Canada), the tests's defined date `Mon, 09 Sep 2011 23:36:00 GMT` won't parse correctly, as the weekday short name for the locale is `Mon.` (extra period).
df69c70
to
2afc395
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enforce Locale.US for AwsRequestSignerTest. Date parsing can fail in other locales.
Specifically, in
en-CA
(Canada), the tests's defined dateMon, 09 Sep 2011 23:36:00 GMT
won't parse correctly, as the weekday short name for the locale isMon.
(extra period).Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1110 ☕️
If you write sample code, please follow the samples format.