Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enforce Locale.US for AwsRequestSignerTest #1111

Merged

Conversation

jmahonin
Copy link
Contributor

@jmahonin jmahonin commented Dec 8, 2022

Enforce Locale.US for AwsRequestSignerTest. Date parsing can fail in other locales.

Specifically, in en-CA (Canada), the tests's defined date Mon, 09 Sep 2011 23:36:00 GMT won't parse correctly, as the weekday short name for the locale is Mon. (extra period).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1110 ☕️

If you write sample code, please follow the samples format.

@jmahonin jmahonin requested a review from a team as a code owner December 8, 2022 15:48
@google-cla
Copy link

google-cla bot commented Dec 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Dec 8, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 8, 2022
@jmahonin jmahonin force-pushed the fix-aws-request-signer-test-locale branch 2 times, most recently from 9b34c47 to df69c70 Compare December 8, 2022 15:53
Date parsing can fail in other locales.

Specifically, in `en-CA` (Canada), the tests's defined date `Mon, 09 Sep 2011 23:36:00 GMT` won't
parse correctly, as the weekday short name for the locale is `Mon.` (extra period).
@jmahonin jmahonin force-pushed the fix-aws-request-signer-test-locale branch from df69c70 to 2afc395 Compare December 8, 2022 15:56
@jmahonin
Copy link
Contributor Author

jmahonin commented Dec 8, 2022

CLA was signed yesterday for a workgroup that jmahonin@decodable.co is a member of. Maybe there's a propagation delay?
CLA verification succeeded

Copy link
Contributor

@aeitzman aeitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimurSadykov TimurSadykov merged commit aeb1218 into googleapis:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General: AwsRequestSignerTest fails in non-US Locales
3 participants