Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds external account authorized user credentials #1129

Merged
merged 6 commits into from
Jan 21, 2023
Merged

feat: adds external account authorized user credentials #1129

merged 6 commits into from
Jan 21, 2023

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Jan 13, 2023

Adds support for external account authorized user credentials.

See go/gcloud-3pi-headful.

@lsirac lsirac requested a review from a team as a code owner January 13, 2023 22:18
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 13, 2023
TimurSadykov
TimurSadykov requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, only test coverage comments

oauth2_http/java/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentials.java Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentials.java Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentials.java Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentialsTest.java Show resolved Hide resolved
TimurSadykov
TimurSadykov approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we might fix codecoverage later

@lsirac lsirac merged commit 06bf21a into googleapis:main Jan 21, 2023
@lsirac lsirac deleted the external_account_authorized_user branch January 21, 2023 06:10
@release-please release-please bot mentioned this pull request Jan 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lsirac @TimurSadykov