fix: create and reuse self signed jwt creds for better performance #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyutongg
reviewed
Feb 13, 2023
arithmetic1728
force-pushed
the
jwt_cache
branch
from
f021efc
to
5753eca
Compare
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
🤖 I have created a release *beep* *boop* --- ## [1.16.0](https://togithub.com/googleapis/google-auth-library-java/compare/v1.15.0...v1.16.0) (2023-02-15) ### Features * Add PKCE to 3LO exchange. ([#1146](https://togithub.com/googleapis/google-auth-library-java/issues/1146)) ([5bf606b](https://togithub.com/googleapis/google-auth-library-java/commit/5bf606bb8f6d863b44e87587eebf51eaeea4a0ae)) ### Bug Fixes * Create and reuse self signed jwt creds for better performance ([#1154](https://togithub.com/googleapis/google-auth-library-java/issues/1154)) ([eaaa8e8](https://togithub.com/googleapis/google-auth-library-java/commit/eaaa8e89cf69d1e0d581443121f315854d52c75f)) * Java doc for DefaultPKCEProvider.java ([#1148](https://togithub.com/googleapis/google-auth-library-java/issues/1148)) ([154c127](https://togithub.com/googleapis/google-auth-library-java/commit/154c1279b3ec96cc34a3225e5e78800ccdda927c)) * Removed url pattern validation for google urls in external account credential configurations ([#1150](https://togithub.com/googleapis/google-auth-library-java/issues/1150)) ([35495b1](https://togithub.com/googleapis/google-auth-library-java/commit/35495b1207ffe11712ee996d3e305449752fb87c)) ### Documentation * Clarified Maven artifact for HTTP-based clients ([#1136](https://togithub.com/googleapis/google-auth-library-java/issues/1136)) ([b49fc13](https://togithub.com/googleapis/google-auth-library-java/commit/b49fc13b10d0e326c7296e2aad7a50ea03e774f5)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
TimurSadykov
pushed a commit
that referenced
this pull request
Feb 17, 2023
…1154) * fix: create and reuse self signed jwt creds for better performance * only create jwt cred when needed
TimurSadykov
pushed a commit
that referenced
this pull request
Feb 17, 2023
…1154) * fix: create and reuse self signed jwt creds for better performance * only create jwt cred when needed
TimurSadykov
pushed a commit
that referenced
this pull request
Feb 17, 2023
…1154) * fix: create and reuse self signed jwt creds for better performance * only create jwt cred when needed
TimurSadykov
pushed a commit
that referenced
this pull request
Feb 17, 2023
…1154) * fix: create and reuse self signed jwt creds for better performance * only create jwt cred when needed
TimurSadykov
pushed a commit
that referenced
this pull request
Feb 17, 2023
…1154) * fix: create and reuse self signed jwt creds for better performance * only create jwt cred when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAPIC clients all use self signed jwt (with scopes) now. Currently we are creating a new jwt credential each time, and this causes perf issue, similar to googleapis/google-cloud-java#3149.
In this PR we create one jwt cred and reuse it each time.
Internal bug: b/268603529