Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds universe_domain to external account creds #1199

Merged
merged 3 commits into from
May 4, 2023

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented May 1, 2023

No description provided.

@lsirac lsirac requested a review from a team as a code owner May 1, 2023 21:55
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 1, 2023
@lsirac lsirac requested a review from aeitzman May 1, 2023 22:29
@lsirac lsirac requested a review from TimurSadykov May 1, 2023 23:17
@TimurSadykov
Copy link
Member

please hold this to use as a sample for cod ownership

@TimurSadykov TimurSadykov added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 2, 2023
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimurSadykov TimurSadykov added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 4, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 608ee87 into googleapis:main May 4, 2023
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants