feat: Byoid metrics framework #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeitzman
assigned aeitzman, TimurSadykov, lsirac and BigTailWolf and unassigned aeitzman
BigTailWolf
approved these changes
Jun 29, 2023
| return "file"; | ||
| } else { | ||
| return "url"; | ||
| } |
There was a problem hiding this comment.
Shall we consider using operand here to make is more concise to increase readability?
There was a problem hiding this comment.
Do you mean a ternary? I personally don't prefer them condition you are checking is long like this.
lsirac
reviewed
Jun 30, 2023
oauth2_http/java/com/google/auth/oauth2/ByoidMetricsOptions.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ByoidMetricsOptions.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
aeitzman
added
the
do not merge
aeitzman
requested review from
arithmetic1728
and removed request for
arithmetic1728
oauth2_http/java/com/google/auth/oauth2/ByoidMetricsHandler.java
Outdated
Show resolved
Hide resolved
lsirac
approved these changes
Jul 7, 2023
oauth2_http/java/com/google/auth/oauth2/ByoidMetricsHandler.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
aeitzman
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding metrics for BYOID credentials.