fix: Remove -Xlint:unchecked, suppress all existing violations, add @CanIgnoreReturnValue #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimurSadykov
reviewed
Nov 7, 2023
|
@sinelaw thanks for the contribution, it makes sense, please see a single nit comment |
Preparation for enabling errorprone
product-auto-label
bot
added
size: m
|
Added another commit - PTAL |
sinelaw
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1323 ☕️
This will prevent further violations from being added without explicit suppressions.
A future step would be to review all existing violations and fix instead of suppressing them.