Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Need a good way to inject secrets besides gcloud & GOOGLE_APPLICATION_CREDENTIALS #146

Closed
lesv opened this issue Jan 11, 2018 · 2 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@lesv
Copy link
Contributor

lesv commented Jan 11, 2018

PR's #94 & #144 both want to find a way to improve ADC for non-google cloud providers.

The ADC algorithm is defined to:

  1. Look at environment variable GOOGLE_APPLICATION_CREDENTIALS
  2. Look for gcloud auth application-default login
  3. Get a service account from the GCP Metadata server (GAE & GCP are a bit different, but it's the same idea)

We should see if there is a way to safely and securely inject a secret like a service account JSON into a container running on another cloud platform. (item 3 above).

@jonparrott said: environment variables should not be used to hold secrets.

This is a very important item for us. We are trying get to the point where docker containers can run anywhere, on GCP, on a competing cloud provider, in their own datacenter, or locally in their laptop with just a change in the configuration.

@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jun 8, 2018
@chingor13 chingor13 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 19, 2018
@JustinBeckwith JustinBeckwith removed triage me I really want to be triaged. 🚨 This issue needs some love. enhancement labels Jun 19, 2018
@JustinBeckwith
Copy link
Contributor

I'm not sure what more is available for us here. @theacodes what other types of auth does python provide?

@theacodes
Copy link

Environment variables pointing to a file that holds the secret (instead of putting the secret in the environment variable) is the best practice. Let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants