Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all types taking Collection<scopes> to do immutable copies #17

Closed
anthmgoogle opened this issue Jun 26, 2015 · 2 comments
Closed

Change all types taking Collection<scopes> to do immutable copies #17

anthmgoogle opened this issue Jun 26, 2015 · 2 comments
Assignees
@chingor13
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@anthmgoogle
Copy link
Contributor

Types like ServiceAccountCredentials handle lists of scopes. The types are effectively immutable, so for safety, all types taking collections of scopes should use ImmutableList.copy(scopes).
@anthmgoogle anthmgoogle mentioned this issue Jun 26, 2015
Merged
@ejona86
Copy link
Contributor

ejona86 commented Jun 26, 2015

ServiceAccountCredentials was the only place I saw that would need to be changed.

@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jun 8, 2018
@chingor13
Copy link
Contributor

ServiceAccountCredentials was fixed in #69 and have been available since 0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chingor13 @JustinBeckwith @ejona86 @anthmgoogle