You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also filed in grpc/grpc-java#8037 as I haven't figured whether this is grpc-auth's bug or google-auth-library's.
Failure
suztomo-macbookpro44% ./gradlew :grpc-auth:test
*** Skipping the build of codegen and compilation of proto files because skipCodegen=true
* Skipping the build of Android projects because skipAndroid=true
> Task :grpc-auth:test
io.grpc.auth.GoogleAuthLibraryCallCredentialsTest > jwtAccessCredentialsInRequestMetadata FAILED
org.junit.ComparisonFailure: expected:<https://example.com[:123/a.service]> but was:<https://example.com[/]>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at io.grpc.auth.GoogleAuthLibraryCallCredentialsTest.jwtAccessCredentialsInRequestMetadata(GoogleAuthLibraryCallCredentialsTest.java:397)
16 tests completed, 1 failed
> Task :grpc-auth:test FAILED
How to reproduce
Checkout grpc-java repository and change google-auth-library dependency:
The test works fine in 0.24.1 (just before 0.25.0).
@arithmetic1728 It seems that some behavioral change was introduced in 0.25.0 version. The only change in 0.25.0s' release note was your PR. Do you think the behavior change on the library (ComparisonFailure: expected:<https://example.com[:123/a.service]> but was:<https://example.com[/]>) was expected or not?
The text was updated successfully, but these errors were encountered:
Yes it is the expected behavior. The reason is in RequestMetadata function of JWT credentials, we extract the http(s)://host_name/ part from the uri and use that as the audience instead of using the original uri. The port 123 and the path /a.service are ignored in this example. Please update the test case.
Also filed in grpc/grpc-java#8037 as I haven't figured whether this is grpc-auth's bug or google-auth-library's.
Failure
How to reproduce
Checkout grpc-java repository and change google-auth-library dependency:
The test works fine in 0.24.1 (just before 0.25.0).
@arithmetic1728 It seems that some behavioral change was introduced in 0.25.0 version. The only change in 0.25.0s' release note was your PR. Do you think the behavior change on the library (
ComparisonFailure: expected:<https://example.com[:123/a.service]> but was:<https://example.com[/]>
) was expected or not?The text was updated successfully, but these errors were encountered: