feat: Support instantiating GoogleAuth with an AuthClient
#1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow downstream clients to support features like Downscoped Tokens without breaking changes
|
Warning: This pull request is touching the following templated files:
|
This test has silently failed for some time as the old bucket did not exist. Fixing.
bcoe
approved these changes
Feb 17, 2022
| return opts; | ||
| }, | ||
| }, | ||
| authClient: new GoogleAuth({auth: oauth2Client}), |
| // GCS object name. | ||
| const objectName = 'cab-first-z2zsauf4sj.txt'; | ||
| const objectName = 'cab-first-"brd3qlsuok.txt'; |
There was a problem hiding this comment.
curious why we changed this object name.
There was a problem hiding this comment.
Good question: The bucket and object previously didn’t exist - and the test has silently failed until this PR as we were asserting a string that existed in the error message (‘first’).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow downstream clients to support features like Downscoped Tokens without breaking changes