fix: Rename auth to authClient & Use Generics for AuthClient
#1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
approved these changes
Feb 17, 2022
bcoe
added
the
do not merge
|
testing against gax, before we merge. |
danielbankhead
changed the title
auth to authClientauth to authClient & Use Generics for AuthClient
bcoe
removed
the
do not merge
|
Great work making this non-breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces type conflicts for downstream consumers.
NOTE: https://github.com/googleapis/nodejs-common/blob/6d1e19edc0765b4d5cc7a37ccc2fcb0e441e0815/src/service.ts#L65-L73 will need to be updated immediately after this change (as
GoogeAuth!=AuthClient)